Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): Map all node keys to display values #3763

Merged
merged 9 commits into from
Oct 9, 2024
Merged

feat(search): Map all node keys to display values #3763

merged 9 commits into from
Oct 9, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 4, 2024 •
edited
Loading

What does this PR do?

  • Maps all node data properties as part of KEY_DATA (now keyFormatters and componentFormatters)
  • Reorganises how getDisplayDetailsForResult() works
    • Changes naming to use "formatter" instead of "map"
    • Flattens and simplifies data structures into key-specific and component-specific maps, and then combines them

Also...

  • Removes feature flag for data only search
  • Sets up test.todos() (follow up PR!)
  • Toggles style of Headline, based on the search facet being data or not

Why?

This now means that all string properties on nodes are searchable, minus a few exceptions (e.g. colours etc).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/search-all-ui branch 5 times, most recently from 5643b2f to b3034a5 Compare October 8, 2024 17:50
@DafyddLlyr DafyddLlyr mentioned this pull request Oct 8, 2024
Merged
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 9, 2024 06:46
@DafyddLlyr DafyddLlyr requested a review from a team October 9, 2024 06:46
jessicamcinchak
jessicamcinchak approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tedious one to review! Pizza overall working as expected, trust that language can be easily foward-tweaked/fixed here 🙌

...c/pages/FlowEditor/components/Sidebar/Search/SearchResultCard/getDisplayDetailsForResult.tsx Show resolved Hide resolved
@DafyddLlyr
Copy link
Contributor Author

Thanks for the review - agreed, pretty tedious stuff!

@DafyddLlyr DafyddLlyr merged commit aad9a43 into main Oct 9, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/search-all-ui branch October 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak